Fix update index on fresh installs #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastrolinux
approved these changes
Dec 31, 2019
There was a problem hiding this comment.
Perfectly working, I tested it on WSL and Win32 with the following command
arduino-cli core update-index --additional-urls http://arduino.esp8266.com/stable/package_esp8266com_index.json I removed the file
C:\Users\LucaCipriani\AppData\Local\Arduino15 right before, also tested by removing some partial dirs
masci
pushed a commit
that referenced
this pull request
Dec 31, 2019
* remove error checking on unused proto field, added deprecation comment * fix typo in function name * do not os.exit in library code * create data dir tree if it doesnt exist
This was referenced Jan 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #529
On
core update-index, with this PR the CLI creates all the directories needed to work properly in case of a first usage with a fresh install.This was a regression shipped in 0.7.0, now the code is more robust and errors bubble up correctly (no more
os.exitfrom within lower layers).